aglinxinyuan commented on PR #4364:
URL: https://github.com/apache/texera/pull/4364#issuecomment-4248251440

   > Looks good! I have one more minor comment which is optional. I personally 
feel it's better to show the file tree of the dataset so that the users can 
easily know what files exist without memorizing the dataset name and version 
number. Similar to the following. What do you think?
   > 
   > <img alt="Image" width="549" height="255" 
src="https://private-user-images.githubusercontent.com/143021053/578223879-6ee443a4-a5db-492b-b3b9-79581f0d9c74.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzYxOTgzNTMsIm5iZiI6MTc3NjE5ODA1MywicGF0aCI6Ii8xNDMwMjEwNTMvNTc4MjIzODc5LTZlZTQ0M2E0LWE1ZGItNDkyYi1iM2I5LTc5NTgxZjBkOWM3NC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwNDE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDQxNFQyMDIwNTNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jYmY3NGRjNTI0NDQ1ZjRkOWQ1YTYzMmEwZThkZjE2ZTUxN2ViMzZjYjNjYTVhZWQ1NTkxZmNjNWY4ZjcyMzg5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZwbmcifQ.t9ZKLUBbp8n3YzLUD1BsbSpA4d01KhcQiyq3EwZL6Wo";>
   
   That's actually a good idea, and it can make the implementation cleaner 
because both selectors will have the exact same UI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to