officialasishkumar commented on code in PR #4377:
URL: https://github.com/apache/texera/pull/4377#discussion_r3090902541
##########
frontend/src/app/workspace/service/workflow-websocket/workflow-websocket.service.ts:
##########
@@ -131,8 +133,8 @@ export class WorkflowWebsocketService {
this.webSocketResponseSubject.next(event as TexeraWebsocketEvent)
);
- // refresh connection status
- this.websocketEvent().subscribe(evt => {
+ // refresh connection status — store the reference so it is torn down in
closeWebsocket()
Review Comment:
Removed the extra wording in the code comment.
##########
frontend/src/app/workspace/service/workflow-websocket/workflow-websocket.service.spec.ts:
##########
@@ -34,4 +34,32 @@ describe("WorkflowWebsocketService", () => {
it("should be created", () => {
expect(service).toBeTruthy();
});
+
Review Comment:
Updated the spec to exercise the real openWebsocket reopen path with a fake
browser WebSocket, so it now checks that the prior subscription is closed on
reopen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
