bobbai00 commented on code in PR #4388:
URL: https://github.com/apache/texera/pull/4388#discussion_r3095218391
##########
bin/k8s/templates/access-control-service-deployment.yaml:
##########
@@ -18,7 +18,7 @@
apiVersion: apps/v1
kind: Deployment
metadata:
- name: {{.Release.Name}}-{{ .Values.accessControlService.name }}
+ name: {{.Release.Name}}-{{ .Values.accessControlService.name }}
Review Comment:
revert this change
##########
bin/k8s/values.yaml:
##########
@@ -247,6 +247,9 @@ texeraEnvVars:
value: ""
- name: USER_SYS_DOMAIN
value: ""
+ - name: AUTH_JWT_SECRET
+ # PLACEHOLDER: must be >=32 chars (256 bits) for HS256. Override in
production.
+ value: "REPLACE_ME_WITH_A_RANDOM_32B_PLACEHOLDER_SECRET"
Review Comment:
can you set this default value to be a valid 256 bits secret? Then in the
comment, saying that this value is for development only. production environment
must change it to a different secret
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
