bobbai00 commented on code in PR #4386:
URL: https://github.com/apache/texera/pull/4386#discussion_r3108360047
##########
common/workflow-operator/src/main/scala/org/apache/texera/amber/operator/source/sql/mysql/MySQLSourceOpDesc.scala:
##########
@@ -19,50 +19,38 @@
package org.apache.texera.amber.operator.source.sql.mysql
-import org.apache.texera.amber.core.executor.OpExecWithClassName
+import org.apache.texera.amber.core.tuple.Schema
import org.apache.texera.amber.core.virtualidentity.{ExecutionIdentity,
WorkflowIdentity}
-import org.apache.texera.amber.core.workflow.{OutputPort, PhysicalOp,
SchemaPropagationFunc}
+import org.apache.texera.amber.core.workflow.{OutputPort, PhysicalOp}
import org.apache.texera.amber.operator.metadata.{OperatorGroupConstants,
OperatorInfo}
import org.apache.texera.amber.operator.source.sql.SQLSourceOpDesc
-import org.apache.texera.amber.operator.source.sql.mysql.MySQLConnUtil.connect
-import org.apache.texera.amber.util.JSONUtils.objectMapper
-import java.sql.{Connection, SQLException}
+import java.sql.Connection
+@deprecated("MySQL source is no longer executable; use PostgreSQLSource
instead.", "1.0.0")
class MySQLSourceOpDesc extends SQLSourceOpDesc {
override def getPhysicalOp(
workflowId: WorkflowIdentity,
executionId: ExecutionIdentity
): PhysicalOp =
- PhysicalOp
- .sourcePhysicalOp(
- workflowId,
- executionId,
- this.operatorIdentifier,
- OpExecWithClassName(
-
"org.apache.texera.amber.operator.source.sql.mysql.MySQLSourceOpExec",
- objectMapper.writeValueAsString(this)
- )
- )
- .withInputPorts(operatorInfo.inputPorts)
- .withOutputPorts(operatorInfo.outputPorts)
- .withPropagateSchema(
- SchemaPropagationFunc(_ => Map(operatorInfo.outputPorts.head.id ->
sourceSchema()))
- )
+ throw new UnsupportedOperationException(
+ "MySQL source operator is no longer executable. Replace this node with "
+
+ "PostgreSQLSource or another supported source."
+ )
override def operatorInfo: OperatorInfo =
OperatorInfo(
- "MySQL Source",
- "Read data from a MySQL instance",
+ "MySQL Source (deprecated)",
Review Comment:
reverted
##########
frontend/src/app/common/service/workflow-persist/workflow-persist.service.spec.ts:
##########
@@ -33,18 +33,18 @@ describe("WorkflowPersistService", () => {
"\"outputPorts\":[{\"portID\":\"output-0\",\"displayName\":null}],\"showAdvanced\":false},"
+
"{\"operatorID\":\"SimpleSink-operator-e4a77a32-e3c9-4c40-a26d-a1aa103cc914\",\"operatorType\":\"SimpleSink\","
+
"\"operatorProperties\":{},\"inputPorts\":[{\"portID\":\"input-0\",\"displayName\":\"\"}],\"outputPorts\":[],"
+
-
"\"showAdvanced\":false},{\"operatorID\":\"MySQLSource-operator-1ee619b1-8884-4564-a136-29ef77dfcc50\","
+
-
"\"operatorType\":\"MySQLSource\",\"operatorProperties\":{\"port\":\"default\",\"search\":false,\"progressive\":false,"
+
+
"\"showAdvanced\":false},{\"operatorID\":\"PostgreSQLSource-operator-1ee619b1-8884-4564-a136-29ef77dfcc50\","
+
Review Comment:
reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
