mengw15 commented on code in PR #4274:
URL: https://github.com/apache/texera/pull/4274#discussion_r3120730371


##########
bin/single-node/docker-compose.yml:
##########
@@ -26,9 +26,37 @@ services:
       - "${MINIO_PORT:-9000}:9000"
     env_file:
       - .env
+    environment:
+      - MINIO_ROOT_USER=${STORAGE_S3_AUTH_USERNAME}
+      - MINIO_ROOT_PASSWORD=${STORAGE_S3_AUTH_PASSWORD}
     volumes:
       - minio_data:/data
     command: server --console-address ":9001" /data
+    healthcheck:
+      test: ["CMD", "curl", "-sf", "http://localhost:9000/minio/health/live";]
+      interval: 5s
+      timeout: 3s
+      retries: 10
+
+  # One-shot init container that creates the Iceberg warehouse bucket on first
+  # startup. MinIO's server image has no built-in "create bucket on boot" flag,
+  # so this sidecar uses the official `mc` client to do it idempotently.

Review Comment:
   Updated. Broadened "workflow result storage" → "the Iceberg warehouse that 
the Lakekeeper service manages" — workflow results are just one kind of data 
that lands in the warehouse, so pinning the comment to "results" felt too 
narrow.                                                                         
                                                                
                     



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to