Xiao-zhen-Liu commented on code in PR #4445:
URL: https://github.com/apache/texera/pull/4445#discussion_r3139936895
##########
frontend/package.json:
##########
@@ -141,7 +141,7 @@
"karma-chrome-launcher": "3.2.0",
"karma-jasmine": "5.1.0",
"nodecat": "2.0.0",
- "nx": "20.0.3",
+ "nx": "21.6.11",
Review Comment:
`nx` is upgraded to `21.6.11`, but the frontend CI workflow still runs on
Node 18. Nx 21 is only officially tested against `24.x`, `^22.12.0`, or
`^20.19.0`, so `test:ci` and `build:ci` are now running outside the supported
toolchain. Could we either move the frontend CI job to a supported Node
version, likely Node 20.19+, or keep Nx on 20.x while CI remains on Node 18?
##########
frontend/package.json:
##########
Review Comment:
The package still advertises `"node": ">=18.16.0"`, but Angular 19.2
requires at least `^18.19.1`, and the upgraded Nx 21 baseline is stricter
still. A contributor can satisfy this `engines` field and still hit unsupported
Angular/Nx tooling. Could we update `engines.node` to match the Node baseline
chosen for CI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
