aglinxinyuan commented on code in PR #4441:
URL: https://github.com/apache/texera/pull/4441#discussion_r3141303575
##########
amber/src/main/scala/org/apache/texera/web/resource/dashboard/user/workflow/WorkflowExecutionsResource.scala:
##########
@@ -247,6 +247,8 @@ object WorkflowExecutionsResource {
OPERATOR_PORT_EXECUTIONS.RESULT_URI
)
.values(eid.id.toInt, globalPortId.serializeAsString, uri.toString)
+ .onConflict()
Review Comment:
fixed.
##########
amber/src/main/scala/org/apache/texera/amber/engine/architecture/controller/execution/WorkflowExecution.scala:
##########
@@ -36,19 +36,13 @@ case class WorkflowExecution() {
/**
* Initializes or retrieves a `RegionExecution` for a given `Region`. If
not already
- * initialized, it creates and returns a new `RegionExecution`; otherwise,
an assertion
- * error is thrown if re-initialization is attempted.
+ * initialized, it creates and returns a new `RegionExecution`。
*
* @param region The `Region` for which to initialize or retrieve the
`RegionExecution`.
* @return The `RegionExecution` associated with the given `Region`.
- * @throws AssertionError if the `RegionExecution` has already been
initialized.
*/
def initRegionExecution(region: Region): RegionExecution = {
- // ensure the region execution hasn't been initialized already.
- assert(
- !regionExecutions.contains(region.id),
- s"RegionExecution of ${region.id} already initialized."
- )
+ regionExecutions.remove(region.id)
Review Comment:
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
