Yicong-Huang commented on code in PR #4220:
URL: https://github.com/apache/texera/pull/4220#discussion_r3142357753
##########
amber/src/main/python/core/runnables/network_receiver.py:
##########
@@ -90,7 +90,8 @@ def data_handler(command: bytes, table: Table) -> int:
# Explicitly set is_control to trigger lazy computation.
# If not set, it may be computed at different times,
# causing hash inconsistencies.
- data_header.tag.is_control = False
+ if not data_header.tag.is_control:
+ data_header.tag.is_control = False
Review Comment:
revisit this. can this be None or other falsy values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
