aglinxinyuan commented on code in PR #4444:
URL: https://github.com/apache/texera/pull/4444#discussion_r3143231165
##########
amber/src/main/scala/org/apache/texera/amber/engine/architecture/scheduling/WorkflowExecutionCoordinator.scala:
##########
@@ -21,19 +21,20 @@ package
org.apache.texera.amber.engine.architecture.scheduling
import com.twitter.util.Future
import com.typesafe.scalalogging.LazyLogging
+import org.apache.texera.amber.core.virtualidentity.OperatorIdentity
import org.apache.texera.amber.core.workflow.{GlobalPortIdentity, PhysicalLink}
import org.apache.texera.amber.engine.architecture.common.{
AkkaActorRefMappingService,
AkkaActorService
}
-import org.apache.texera.amber.engine.architecture.controller.ControllerConfig
+import
org.apache.texera.amber.engine.architecture.controller.{ControllerConfig,
WorkflowScheduler}
import
org.apache.texera.amber.engine.architecture.controller.execution.WorkflowExecution
import org.apache.texera.amber.engine.common.rpc.AsyncRPCClient
import scala.collection.mutable
class WorkflowExecutionCoordinator(
- getNextRegions: () => Set[Region],
+ workflowScheduler: WorkflowScheduler,
Review Comment:
Updated. I moved the jump-back state into `WorkflowExecutionCoordinator` and
stopped mutating the scheduler.
Now the scheduler only keeps the static generated `Schedule`, while the
coordinator tracks the current execution position and handles
`jumpToOperator(...)`.
##########
amber/src/main/scala/org/apache/texera/amber/engine/architecture/controller/WorkflowScheduler.scala:
##########
@@ -54,4 +55,6 @@ class WorkflowScheduler(
def getNextRegions: Set[Region] = if (!schedule.hasNext) Set() else
schedule.next()
+ def jumpToOperator(opId: OperatorIdentity): Unit =
schedule.jumpToOperator(opId)
Review Comment:
Updated. I removed the jump behavior from `WorkflowScheduler`.
`WorkflowScheduler` now only owns the static schedule generation/result. The
coordinator is responsible for changing the execution position.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
