Yicong-Huang commented on code in PR #4411:
URL: https://github.com/apache/texera/pull/4411#discussion_r3164968125
##########
bin/fix-format.sh:
##########
@@ -67,14 +67,14 @@ esac
# --- 1) Scala formatting ---
if $run_scala; then
- tx_info "Running sbt scalafmtAll at repo root..."
+ tx_info "Running sbt scalafmtAll and scalafixAll at repo root..."
if ! command -v sbt >/dev/null 2>&1; then
tx_error "sbt not found. Please install sbt."
exit 1
fi
(
cd "$TEXERA_HOME"
- sbt scalafmtAll
+ sbt scalafmtAll scalafixAll
Review Comment:
I have a question.. does `scalafixAll` change src code?
In CI we should only "check" if the code is fitting requirement, but should
not "fix" the code which are not fitting requirement. If we only fix the code
in CI and then does not fix the code in PR, we are surpassing formatting
issues...
cc @aglinxinyuan @kunwp1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
