aglinxinyuan commented on code in PR #4488: URL: https://github.com/apache/texera/pull/4488#discussion_r3171383459
########## amber/src/main/python/core/models/state.py: ########## @@ -15,58 +15,56 @@ # specific language governing permissions and limitations # under the License. -from dataclasses import dataclass -from pandas import DataFrame -from pyarrow import Table -from typing import Optional +import base64 +import json +from typing import Any, Dict, TypeAlias -from .schema import Schema, AttributeType -from .schema.attribute_type import FROM_PYOBJECT_MAPPING +from .schema import Schema +from .tuple import Tuple +State: TypeAlias = Dict[str, Any] Review Comment: Implemented. I made Python State a concrete runtime type by changing it from a TypeAlias to a minimal dict subclass. This lets main_loop.py safely dispatch on State, and lets output_manager.py use isinstance(payload, State) instead of the broader dict check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
