Yicong-Huang commented on code in PR #4658:
URL: https://github.com/apache/texera/pull/4658#discussion_r3176287391
##########
frontend/package.json:
##########
@@ -2,7 +2,7 @@
"name": "gui",
"version": "0.0.0",
"engines": {
- "node": ">=20.19.0"
+ "node": ">=24.0.0"
Review Comment:
This we need to alert all developers to upgrade. do we have to do it now?
##########
.github/workflows/build.yml:
##########
@@ -59,7 +59,7 @@ env:
jobs:
frontend:
if: ${{ inputs.run_frontend }}
- name: ${{ format('frontend{0} ({1}, 18)', inputs.job_name_suffix,
matrix.os) }}
+ name: ${{ format('frontend{0} ({1}, 24)', inputs.job_name_suffix,
matrix.os) }}
Review Comment:
let's remove those names? we don't need them any more to match a check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
