Yicong-Huang opened a new pull request, #4806:
URL: https://github.com/apache/texera/pull/4806

   ### What changes were proposed in this PR?
   
   Adds scalatest coverage for three small `common/workflow-core` modules that 
had no dedicated specs:
   
   - `PartitionInfoSpec` — `satisfies` reflexivity + UnknownPartition 
universal-accepter + non-symmetric semantics, `merge` 
same/different/RangePartition-override, `RangePartition.apply` factory's 
empty-names fallback to UnknownPartition, `@JsonSubTypes` registration set, 
case-class equality.
   - `WorkflowRuntimeExceptionSpec` — all four constructor overloads 
(message-only, message + cause + workerId, cause + workerId, cause-only, 
no-arg), null-cause fallback, `toString` returning the raw message field.
   - `WorkflowContextSpec` — companion-object pinned defaults (workflow id 
`1L`, execution id `1L`), default-constructed instance honours those, `var` 
field reassignment, constructor argument override.
   
   ### Any related issues, documentation, discussions?
   
   Closes #4804.
   
   Bug pinned in the spec with explanatory comment (filed separately as a Bug 
issue): the `@JsonSubTypes` annotation on `PartitionInfo` does not register 
`OneToOnePartition`, so Jackson cannot deserialize a polymorphic payload that 
selects that subclass via the `type` field. The other five concrete partitions 
are all registered.
   
   ### How was this PR tested?
   
   ```
   sbt scalafmtCheckAll
   sbt "WorkflowCore/testOnly 
org.apache.texera.amber.core.workflow.PartitionInfoSpec 
org.apache.texera.amber.core.WorkflowRuntimeExceptionSpec 
org.apache.texera.amber.core.workflow.WorkflowContextSpec"
   ```
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (claude-opus-4-7)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to