Yicong-Huang opened a new pull request, #4816:
URL: https://github.com/apache/texera/pull/4816

   ### What changes were proposed in this PR?
   
   Adds scalatest coverage for three logical-operator descriptors that had no 
dedicated specs:
   
   - `sleep/SleepOpDesc` — operatorInfo (Sleep, Control group, 1 input + 1 
output) and `getPhysicalOp` (non-parallelizable, single-worker, SleepOpExec 
class wired in).
   - `intersect/IntersectOpDesc` — operatorInfo (Intersect, Set group, 2 input 
ports with PortIdentity 0/1, blocking output) and `getPhysicalOp` 
(HashPartition required on both inputs, derived HashPartition for any input 
combination).
   - `source/fetcher/URLFetcherOpDesc` — operatorInfo (URL Fetcher, API group, 
source-shaped 0-in/1-out), `sourceSchema` (UTF-8 → STRING, RAW_BYTES → ANY, 
null fallthrough → ANY), and `getPhysicalOp` (URLFetcherOpExec class wired in).
   
   ### Any related issues, documentation, discussions?
   
   Closes #4814.
   
   Bug filed separately: `URLFetcherOpDesc.sourceSchema` silently falls back to 
`ANY` when `decodingMethod` is left at its `null` default rather than guarding 
non-null. Pinned in the spec as the current behavior.
   
   Drive-by note (already filed as #4813): `source/scan/json/JSONUtil.scala` is 
a byte-for-byte duplicate of `workflow-core/util/JSONUtils.scala::JSONToMap`. 
Not adding a redundant spec for it; its tests live with `JSONUtilsSpec` from 
#4716.
   
   ### How was this PR tested?
   
   ```
   sbt scalafmtCheckAll
   sbt "WorkflowOperator/testOnly 
org.apache.texera.amber.operator.sleep.SleepOpDescSpec 
org.apache.texera.amber.operator.intersect.IntersectOpDescSpec 
org.apache.texera.amber.operator.source.fetcher.URLFetcherOpDescSpec"
   ```
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (claude-opus-4-7)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to