Copilot commented on code in PR #4658:
URL: https://github.com/apache/texera/pull/4658#discussion_r3177629030
##########
AGENTS.md:
##########
@@ -17,7 +17,7 @@ Major areas:
- `config-service/`, `access-control-service/`, `file-service/`,
`computing-unit-managing-service/`, `workflow-compiling-service/`: backend
services wired through `build.sbt`.
-- `frontend/`: Angular application. Uses Yarn 4.14.1, Node >= 20.19.0, Nx,
+- `frontend/`: Angular application. Uses Yarn 4.14.1, Node >= 24.0.0, Nx,
Prettier, ESLint, Karma/Jasmine, and ng-zorro.
Review Comment:
AGENTS.md states the frontend uses Yarn 4.14.1 via Corepack, but
`bin/texera-web-application.dockerfile` pins Yarn 4.5.1 in its frontend build
stage. With the Node bump, it would be good to keep these aligned (either
update the Dockerfile to 4.14.1 or note in docs that the Docker image build
uses a different Yarn version).
##########
.github/workflows/build.yml:
##########
@@ -63,7 +63,6 @@ env:
jobs:
frontend:
if: ${{ inputs.run_frontend }}
- name: ${{ format('frontend{0} ({1}, 18)', inputs.job_name_suffix,
matrix.os) }}
runs-on: ${{ matrix.os }}
Review Comment:
The PR description says the frontend job name format string was updated to
show Node 24, but the `name:` field for the `frontend` job was removed
entirely. If the intent is to keep the explicit job name (including Node
version), reintroduce it with the updated version; otherwise please update the
PR description to reflect that job naming was removed.
##########
.github/workflows/build.yml:
##########
@@ -348,7 +347,6 @@ jobs:
python:
if: ${{ inputs.run_python }}
Review Comment:
The `python` job’s `name:` field was removed. This changes how the job is
displayed in GitHub Actions (and may affect any tooling that expects stable job
names). If this wasn’t intentional, please restore the `name:` line; if it was,
consider calling it out in the PR description since it’s unrelated to the Node
24 bump.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
