Yicong-Huang opened a new pull request, #4869: URL: https://github.com/apache/texera/pull/4869
### What changes were proposed in this PR? Move the `--code-coverage` flag from `.github/workflows/build.yml` into the `test:ci` script in `frontend/package.json`. No behavior change — the same `nx test ... --code-coverage` command runs, just sourced from `package.json` instead of inlined in the workflow. ### Why Frontend test-flag tweaks (changing reporter, switching coverage provider, adjusting watch mode, etc.) should live next to the script that runs the tests, not in the CI workflow file. Removes a small reason to touch `.github/workflows/build.yml` whenever a frontend test option changes. ### Diff ```yaml # .github/workflows/build.yml - run: yarn --cwd frontend run test:ci --code-coverage + run: yarn --cwd frontend run test:ci ``` ```jsonc // frontend/package.json - "test:ci": "node ... nx.js test --watch=false --progress=false", + "test:ci": "node ... nx.js test --watch=false --progress=false --code-coverage", ``` ### Any related issues, documentation, discussions? Prep for #4862 — the Vitest migration PR currently has to change build.yml to swap `--code-coverage` (Karma flag) for the new builder's flags. With this refactor in first, that PR's CI yml diff goes away entirely. ### How was this PR tested? `yarn --cwd frontend run test:ci` produces `coverage/lcov.info` under Karma exactly the same as before; the CI workflow's frontend job exercises the same script. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Opus 4.7 (1M context) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
