Yicong-Huang commented on code in PR #4889:
URL: https://github.com/apache/texera/pull/4889#discussion_r3179270047
##########
frontend/src/app/workspace/component/result-panel/error-frame/error-frame.component.spec.ts:
##########
@@ -32,10 +32,9 @@ describe("ConsoleFrameComponent", () => {
let component: ErrorFrameComponent;
let fixture: ComponentFixture<ErrorFrameComponent>;
Review Comment:
Fixed in b525457bb4: `describe("ConsoleFrameComponent", ...)` →
`describe("ErrorFrameComponent", ...)` so the suite name matches the component
under test.
##########
frontend/src/app/workspace/component/workflow-editor/context-menu/context-menu/context-menu.component.spec.ts:
##########
@@ -116,6 +115,7 @@ describe("ContextMenuComponent", () => {
...commonTestProviders,
],
imports: [
+ ContextMenuComponent,
HttpClientModule,
ReactiveFormsModule,
Review Comment:
Swapped in b525457bb4: `HttpClientModule` is replaced by
`HttpClientTestingModule` at both the import statement and inside the TestBed
`imports` array. The spec can no longer reach a real backend.
##########
frontend/src/app/workspace/component/workflow-editor/mini-map/mini-map.component.spec.ts:
##########
@@ -47,9 +46,9 @@ describe("MiniMapComponent", () => {
},
...commonTestProviders,
],
- imports: [HttpClientTestingModule, DragDropModule],
+ imports: [MiniMapComponent, WorkflowEditorComponent,
HttpClientTestingModule, DragDropModule],
Review Comment:
Dropped in b525457bb4: removed `WorkflowEditorComponent` from both the
import statement and the TestBed `imports` array, since this spec only
constructs `MiniMapComponent`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
