Yicong-Huang commented on code in PR #4908: URL: https://github.com/apache/texera/pull/4908#discussion_r3179874801
########## common/workflow-operator/src/test/scala/org/apache/texera/amber/operator/aggregate/AggregationOperationSpec.scala: ########## @@ -0,0 +1,235 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.texera.amber.operator.aggregate + +import org.apache.texera.amber.core.tuple.{Attribute, AttributeType, Schema, Tuple} +import org.scalatest.flatspec.AnyFlatSpec + +class AggregationOperationSpec extends AnyFlatSpec { + + // --- helpers --------------------------------------------------------------- + + private def schemaWith(name: String, t: AttributeType): Schema = + new Schema(new Attribute(name, t)) + + private def tupleOf(name: String, t: AttributeType, value: AnyRef): Tuple = + Tuple.builder(schemaWith(name, t)).add(new Attribute(name, t), value).build() + + private def op( + func: AggregationFunction, + attribute: String = "v", + resultAttribute: String = "r" + ): AggregationOperation = { + val o = new AggregationOperation() + o.aggFunction = func + o.attribute = attribute + o.resultAttribute = resultAttribute + o + } + + // --- getAggregationAttribute ----------------------------------------------- + + "AggregationOperation.getAggregationAttribute" should "preserve the input type for SUM" in { + val attr = op(AggregationFunction.SUM).getAggregationAttribute(AttributeType.LONG) + assert(attr.getName == "r") + assert(attr.getType == AttributeType.LONG) + } + + it should "produce INTEGER for COUNT regardless of input type" in { + val attr = op(AggregationFunction.COUNT).getAggregationAttribute(AttributeType.STRING) + assert(attr.getType == AttributeType.INTEGER) + } + + it should "produce DOUBLE for AVERAGE regardless of input type" in { + val attr = op(AggregationFunction.AVERAGE).getAggregationAttribute(AttributeType.LONG) + assert(attr.getType == AttributeType.DOUBLE) + } + + it should "preserve the input type for MIN and MAX" in { + assert( + op(AggregationFunction.MIN).getAggregationAttribute(AttributeType.INTEGER).getType == + AttributeType.INTEGER + ) + assert( + op(AggregationFunction.MAX).getAggregationAttribute(AttributeType.TIMESTAMP).getType == + AttributeType.TIMESTAMP + ) + } + + it should "produce STRING for CONCAT" in { + assert( + op(AggregationFunction.CONCAT).getAggregationAttribute(AttributeType.STRING).getType == + AttributeType.STRING + ) + } + + it should "throw RuntimeException when aggFunction is null" in { + val ex = intercept[RuntimeException] { + op(null).getAggregationAttribute(AttributeType.INTEGER) + } + assert(ex.getMessage.contains("Unknown aggregation function")) + } + + // --- getAggFunc: type validation ------------------------------------------- + + "AggregationOperation.getAggFunc" should "throw for non-numeric types on SUM" in { + val ex = intercept[UnsupportedOperationException] { + op(AggregationFunction.SUM).getAggFunc(AttributeType.STRING) + } + assert(ex.getMessage.contains("Unsupported attribute type for sum")) + } + + it should "throw for non-numeric types on MIN and MAX" in { + intercept[UnsupportedOperationException] { + op(AggregationFunction.MIN).getAggFunc(AttributeType.STRING) + } + intercept[UnsupportedOperationException] { + op(AggregationFunction.MAX).getAggFunc(AttributeType.BOOLEAN) + } + } + + it should "throw UnsupportedOperationException when aggFunction is null" in { + val ex = intercept[UnsupportedOperationException] { + op(null).getAggFunc(AttributeType.INTEGER) + } + assert(ex.getMessage.contains("Unknown aggregation function")) + } + + // --- getAggFunc: SUM behavior ---------------------------------------------- + + "SUM aggregation" should "init at the type's zero, accumulate values, and merge partial sums" in { + val agg = op(AggregationFunction.SUM).getAggFunc(AttributeType.INTEGER) + val zero = agg.init().asInstanceOf[Integer] + assert(zero == 0) + val t1 = tupleOf("v", AttributeType.INTEGER, Int.box(3)) + val t2 = tupleOf("v", AttributeType.INTEGER, Int.box(5)) + val partial = agg.iterate(agg.iterate(zero, t1), t2) + assert(partial.asInstanceOf[Integer] == 8) + val merged = agg.merge(partial, partial) + assert(merged.asInstanceOf[Integer] == 16) + assert(agg.finalAgg(merged).asInstanceOf[Integer] == 16) + } Review Comment: I recall those are tested in AggregateOp? we don't need to test the same thing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
