aglinxinyuan commented on code in PR #4912: URL: https://github.com/apache/texera/pull/4912#discussion_r3179924431
########## common/workflow-operator/src/test/scala/org/apache/texera/amber/operator/sink/ProgressiveUtilsSpec.scala: ########## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.texera.amber.operator.sink + +import org.apache.texera.amber.core.tuple.{Attribute, AttributeType, Schema, Tuple} +import org.scalatest.flatspec.AnyFlatSpec + +class ProgressiveUtilsSpec extends AnyFlatSpec { + + // --- helpers --------------------------------------------------------------- + + private val baseSchema: Schema = new Schema( + new Attribute("id", AttributeType.INTEGER), + new Attribute("name", AttributeType.STRING) + ) + + // outputSchema = flag column prepended to baseSchema + private val outputSchema: Schema = new Schema( + ProgressiveUtils.insertRetractFlagAttr, + new Attribute("id", AttributeType.INTEGER), + new Attribute("name", AttributeType.STRING) + ) + + private def baseTuple(id: Int, name: String): Tuple = + Tuple + .builder(baseSchema) + .add(new Attribute("id", AttributeType.INTEGER), Int.box(id)) + .add(new Attribute("name", AttributeType.STRING), name) + .build() + + // --- insertRetractFlagAttr ------------------------------------------------- + + "ProgressiveUtils.insertRetractFlagAttr" should "be a BOOLEAN attribute named __internal_is_insertion" in { + val attr = ProgressiveUtils.insertRetractFlagAttr + assert(attr.getName == "__internal_is_insertion") + assert(attr.getType == AttributeType.BOOLEAN) + } + + // --- addInsertionFlag / addRetractionFlag ---------------------------------- + + "ProgressiveUtils.addInsertionFlag" should "prepend the flag column with value true" in { + val flagged = ProgressiveUtils.addInsertionFlag(baseTuple(1, "alice"), outputSchema) + assert(flagged.getSchema == outputSchema) + assert(flagged.getField[Boolean](ProgressiveUtils.insertRetractFlagAttr.getName) == true) + assert(flagged.getField[Integer]("id") == 1) + assert(flagged.getField[String]("name") == "alice") + } + + "ProgressiveUtils.addRetractionFlag" should "prepend the flag column with value false" in { + val flagged = ProgressiveUtils.addRetractionFlag(baseTuple(2, "bob"), outputSchema) + assert(flagged.getField[Boolean](ProgressiveUtils.insertRetractFlagAttr.getName) == false) + assert(flagged.getField[Integer]("id") == 2) + assert(flagged.getField[String]("name") == "bob") + } + + it should "fail an assertion if the input tuple already has the flag column" in { + val alreadyFlagged = ProgressiveUtils.addInsertionFlag(baseTuple(3, "x"), outputSchema) + val ex = intercept[AssertionError] { + ProgressiveUtils.addRetractionFlag(alreadyFlagged, outputSchema) + } + // Don't pin the exact message; locking in the AssertionError is enough. + assert(ex != null) + } + + // --- isInsertion ----------------------------------------------------------- + + "ProgressiveUtils.isInsertion" should "return true for an unflagged tuple" in { + // Tuples without the flag column default to insertion (the unflagged + // default in the engine is "+"). + assert(ProgressiveUtils.isInsertion(baseTuple(1, "x"))) + } + + it should "return true when the flag column is present and true" in { + val flagged = ProgressiveUtils.addInsertionFlag(baseTuple(1, "x"), outputSchema) + assert(ProgressiveUtils.isInsertion(flagged)) + } + + it should "return false when the flag column is present and false" in { + val flagged = ProgressiveUtils.addRetractionFlag(baseTuple(1, "x"), outputSchema) + assert(!ProgressiveUtils.isInsertion(flagged)) + } + + // --- getTupleFlagAndValue -------------------------------------------------- + + "ProgressiveUtils.getTupleFlagAndValue" should "split an insertion-flagged tuple into (true, base tuple)" in { Review Comment: Looked for it — there is no public resolution API in the current codebase. `ProgressiveUtils` only exposes producers (`addInsertionFlag` / `addRetractionFlag`) and readers (`isInsertion` / `getTupleFlagAndValue`); there is no shared utility (e.g., a deduplicating fold over a flagged stream that produces a materialized `Set[Tuple]`). I checked usages of `insertRetractFlagAttr`, `__internal_is_insertion`, and `getTupleFlagAndValue` — only the file itself references them, no downstream consumer applies retractions to undo prior insertions. Are you thinking of an API that used to exist and has since been removed, or one that *should* exist? Happy to either (a) add a `materialize(stream): Set[Tuple]` helper here and test it as part of this PR, or (b) leave that as a follow-up issue. Let me know which you'd prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
