SarahAsad23 commented on code in PR #4902:
URL: https://github.com/apache/texera/pull/4902#discussion_r3183734491
##########
amber/src/main/scala/org/apache/texera/web/resource/pythonvirtualenvironment/PveManager.scala:
##########
@@ -121,18 +127,6 @@ object PveManager {
return
}
- if (!Files.exists(requirementsPath)) {
- queue.put(s"[PVE][ERR] requirements.txt not found at
${requirementsPath.toAbsolutePath}")
- return
- }
-
- if (!Files.exists(operatorRequirementsPath)) {
- queue.put(
- s"[PVE][ERR] operator-requirements.txt not found at
${operatorRequirementsPath.toAbsolutePath}"
- )
- return
- }
-
Review Comment:
This is duplicate code. I have the same check at the beginning of the
function. I added a comment in the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
