aglinxinyuan opened a new pull request, #4954: URL: https://github.com/apache/texera/pull/4954
### What changes were proposed in this PR? Adds `PortIdentitySerdeSpec` covering three Jackson / VFS-URI serde helpers in `org.apache.texera.amber.util.serde`, none of which had a unit test: | Helper | Pinned by this spec | | --- | --- | | `GlobalPortIdentitySerde.serializeAsString` / `deserializeFromString` | Default + per-field round-trip; exact format pin (default + non-default values); special-character pass-through (dashes / dots); negative `portId`; no-underscore invariant (VFS-URI compatibility); seven negative paths — completely malformed, missing field, wrong field order, trailing content, empty body, non-numeric `portId` → `NumberFormatException`, non-boolean flag → `IllegalArgumentException` | | `PortIdentityKeySerializer.portIdToString` | Exact `id_internal` format. | | `PortIdentityKeySerializer` + `PortIdentityKeyDeserializer` (Jackson wiring) | A real `ObjectMapper` registered with the same module shape that `JSONUtils.objectMapper` uses, round-tripping `Map[PortIdentity, String]` and an empty map. | | `PortIdentityKeyDeserializer.deserializeKey` | Happy-path via the Map round-trip + four negative paths (non-integer id, non-boolean flag, missing-separator with non-numeric body, missing-separator with numeric-only body). | No production code changed; this is test-only. ### Any related issues, documentation, discussions? Closes #4953 ### How was this PR tested? ``` sbt "WorkflowCore/Test/testOnly org.apache.texera.amber.util.serde.PortIdentitySerdeSpec" # → 20 tests, all pass sbt "WorkflowCore/Test/scalafmtCheck" # → clean ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 4.7) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
