aglinxinyuan commented on code in PR #4938: URL: https://github.com/apache/texera/pull/4938#discussion_r3193410539
########## .jvmopts: ########## @@ -0,0 +1,18 @@ +# JVM options for sbt's launcher script. Read by `sbt` from the build +# root and applied to sbt's own JVM (which also runs the tests when +# Test / fork := false, the default for this project). +# +# JDK 17+ --add-opens flags required by: +# - Apache Pekko (dispatcher / mailbox / scheduler use sun.misc.Unsafe +# via jdk.internal.misc, plus java.lang for virtual threads and Review Comment: do we have virtual threads? ########## .jvmopts: ########## @@ -0,0 +1,18 @@ +# JVM options for sbt's launcher script. Read by `sbt` from the build +# root and applied to sbt's own JVM (which also runs the tests when +# Test / fork := false, the default for this project). +# +# JDK 17+ --add-opens flags required by: +# - Apache Pekko (dispatcher / mailbox / scheduler use sun.misc.Unsafe +# via jdk.internal.misc, plus java.lang for virtual threads and +# sun.nio.ch for Aeron / NIO channels). Review Comment: do we have Aeron / NIO channels? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
