aglinxinyuan commented on code in PR #4490:
URL: https://github.com/apache/texera/pull/4490#discussion_r3198154729


##########
amber/src/main/scala/org/apache/texera/amber/engine/architecture/messaginglayer/OutputManager.scala:
##########
@@ -245,7 +256,7 @@ class OutputManager(
         writerThread.join()
       case None =>
     }
-
+    this.stateWriters.remove(outputPortId).foreach(_.close())

Review Comment:
   Mirrored the result writer-thread pattern: state writes now go through an 
OutputPortResultWriterThread (Scala) / PortStorageWriter (Python) per output 
port, so the DataProcessor / MainLoop thread just enqueues onto a queue instead 
of blocking on Iceberg I/O (4428c9d5b0).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to