Ma77Ball opened a new pull request, #4978:
URL: https://github.com/apache/texera/pull/4978
### What changes were proposed in this PR?
AmberFIFOChannel.getPortId called this.portId.get on an
Option[PortIdentity] that defaults to None. Calling getPortId before setPortId
threw a bare NoSuchElementException with no message, giving callers no
indication of which channel was misconfigured or what setup step was missed.
Replaced .get with .getOrElse(throw new IllegalStateException(...)) so the
exception identifies the channel and points the caller at the missing setPortId
call.
### Any related issues, documentation, discussions?
Closes: #4818
### How was this PR tested?
Updated the existing AmberFIFOChannelSpec test that covered this path — it
previously asserted NoSuchElementException and now asserts
IllegalStateException with message content checks ("portId has not been set"
and the channel ID string). All 13 specs pass.
### Was this PR authored or co-authored using generative AI tooling?
Co-Authored with Claude Opus 4.7 in compliance with ASF
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
