aglinxinyuan opened a new pull request, #4980:
URL: https://github.com/apache/texera/pull/4980
Closes #4979.
## Summary
`download.service.ts` carried a top-level `var contentDisposition =
require("content-disposition")` that was never read or called. Removing the
dead require lets us drop both the `content-disposition` runtime dep and its
`@types/content-disposition` companion.
## Diff at a glance
| File | Change |
|---|---|
| `frontend/src/app/dashboard/service/user/download/download.service.ts` |
drop the dead `require("content-disposition")` line |
| `frontend/package.json` | remove `content-disposition` (deps) and
`@types/content-disposition` (devDeps) |
| `frontend/LICENSE-binary` | remove `[email protected]` from the
bundled-license roll-up |
| `frontend/yarn.lock` | regenerated — drops the transitive entries for free
|
## Before → After (download.service.ts)
```
┌──────────────────────────────────────────────────────────────────┐
│ ...imports... │
│ │
│ var contentDisposition = require("content-disposition"); ← dead │
│ │
│ export const EXPORT_BASE_URL = ... │
└──────────────────────────────────────────────────────────────────┘
↓
┌──────────────────────────────────────────────────────────────────┐
│ ...imports... │
│ │
│ export const EXPORT_BASE_URL = ... │
└──────────────────────────────────────────────────────────────────┘
```
## Test plan
- [x] `yarn install` succeeds and rewrites `yarn.lock` (transitive entries
fall away)
- [x] `yarn build` exits 0
- [x] `yarn test` stays at 63 / 269 parity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
