Yicong-Huang commented on code in PR #4986: URL: https://github.com/apache/texera/pull/4986#discussion_r3209571656
########## .github/workflows/comment-commands.yml: ########## @@ -0,0 +1,183 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# /take, /untake, /request-review, and /unrequest-review comment commands. +# +# Triage state is no longer materialized as a label — it is the search +# filter `is:issue is:open no:assignee`. Anyone can self-claim an issue +# by commenting `/take` (and self-release with `/untake`); PR-driven +# assignee sync is handled by `pr-assignment.yml`. +# +# On pull requests, the author or any committer (write/maintain/admin) +# can request or cancel reviewer requests via `/request-review @user +# [@user ...]` and `/unrequest-review @user [@user ...]`. We avoid the +# `/review` namespace so it stays free for future use (e.g. self-review). +name: Comment commands +on: + issue_comment: + types: [created] + +permissions: + issues: write + pull-requests: write + +jobs: + take: + # The startsWith filter at the job level keeps unrelated comments + # from allocating a runner; the regex inside the script enforces an + # exact `/take` or `/untake` so suffixes like `/take this` do not + # silently match. + if: >- + github.event_name == 'issue_comment' + && github.event.action == 'created' + && github.event.issue.pull_request == null + && github.event.comment.user.type != 'Bot' + && (startsWith(github.event.comment.body, '/take') + || startsWith(github.event.comment.body, '/untake')) + runs-on: ubuntu-latest + steps: + - uses: actions/github-script@v8 + with: + github-token: ${{ secrets.GITHUB_TOKEN }} + script: | + const body = (context.payload.comment.body || '').trim(); + const issue_number = context.payload.issue.number; + const login = context.payload.comment.user.login; + const { owner, repo } = context.repo; + core.info( + `take/untake candidate: ${login} on issue #${issue_number}; ` + + `body=${JSON.stringify(body)}`, + ); + + if (/^\/take\s*$/.test(body)) { + try { + await github.rest.issues.addAssignees({ + owner, repo, issue_number, assignees: [login], + }); + core.info(`Assigned ${login} to issue #${issue_number}`); + } catch (e) { + core.warning( + `addAssignees on #${issue_number} failed: ${e.message}`, + ); + } + } else if (/^\/untake\s*$/.test(body)) { + try { + await github.rest.issues.removeAssignees({ + owner, repo, issue_number, assignees: [login], + }); + core.info(`Unassigned ${login} from issue #${issue_number}`); + } catch (e) { + core.warning( + `removeAssignees on #${issue_number} failed: ${e.message}`, + ); + } + } else { + core.info( + `Comment does not match exact '/take' or '/untake'; skipping.`, + ); + } + + request-review: + # Job-level startsWith gate avoids spinning up a runner for every + # PR comment; the regex inside the script enforces the exact shape. + if: >- + github.event_name == 'issue_comment' + && github.event.action == 'created' + && github.event.issue.pull_request != null + && github.event.comment.user.type != 'Bot' + && (startsWith(github.event.comment.body, '/request-review') + || startsWith(github.event.comment.body, '/unrequest-review')) + runs-on: ubuntu-latest + steps: + - uses: actions/github-script@v8 + with: + github-token: ${{ secrets.GITHUB_TOKEN }} + script: | + const body = (context.payload.comment.body || '').trim(); + const pull_number = context.payload.issue.number; + const commenter = context.payload.comment.user.login; + const author = context.payload.issue.user.login; + const { owner, repo } = context.repo; + + const match = body.match( + /^\/(request-review|unrequest-review)\b(.*)$/s, + ); + if (!match) { + core.info(`Comment does not match exact command; skipping.`); + return; + } + const action = match[1]; + + // Authorize: PR author always, otherwise commenter must hold + // write/maintain/admin on the repo (i.e. a committer). + let allowed = commenter === author; + if (!allowed) { + try { + const { data: perm } = + await github.rest.repos.getCollaboratorPermissionLevel({ + owner, repo, username: commenter, + }); + allowed = ['write', 'maintain', 'admin'].includes( + perm.permission, + ); + } catch (e) { + core.warning( + `permission lookup for ${commenter} failed: ${e.message}`, + ); + } + } + if (!allowed) { + core.info( + `${commenter} is neither author nor committer on ` + + `#${pull_number}; skipping.`, + ); + return; + } + + // Parse @user and @org/team mentions; route teams to the + // team_reviewers bucket. Strip self so the API doesn't + // reject the whole atomic call over one bad name. + const reviewers = []; + const team_reviewers = []; + for (const [, h] of match[2].matchAll( Review Comment: Just curious, can we also allow copilot to be requested as reviewer? ########## .github/workflows/comment-commands.yml: ########## @@ -0,0 +1,183 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# /take, /untake, /request-review, and /unrequest-review comment commands. +# +# Triage state is no longer materialized as a label — it is the search +# filter `is:issue is:open no:assignee`. Anyone can self-claim an issue +# by commenting `/take` (and self-release with `/untake`); PR-driven +# assignee sync is handled by `pr-assignment.yml`. +# +# On pull requests, the author or any committer (write/maintain/admin) +# can request or cancel reviewer requests via `/request-review @user +# [@user ...]` and `/unrequest-review @user [@user ...]`. We avoid the +# `/review` namespace so it stays free for future use (e.g. self-review). +name: Comment commands +on: + issue_comment: + types: [created] + +permissions: + issues: write + pull-requests: write + +jobs: + take: + # The startsWith filter at the job level keeps unrelated comments + # from allocating a runner; the regex inside the script enforces an + # exact `/take` or `/untake` so suffixes like `/take this` do not + # silently match. + if: >- + github.event_name == 'issue_comment' + && github.event.action == 'created' + && github.event.issue.pull_request == null + && github.event.comment.user.type != 'Bot' + && (startsWith(github.event.comment.body, '/take') + || startsWith(github.event.comment.body, '/untake')) + runs-on: ubuntu-latest + steps: + - uses: actions/github-script@v8 + with: + github-token: ${{ secrets.GITHUB_TOKEN }} + script: | + const body = (context.payload.comment.body || '').trim(); + const issue_number = context.payload.issue.number; + const login = context.payload.comment.user.login; + const { owner, repo } = context.repo; + core.info( + `take/untake candidate: ${login} on issue #${issue_number}; ` + + `body=${JSON.stringify(body)}`, + ); + + if (/^\/take\s*$/.test(body)) { + try { + await github.rest.issues.addAssignees({ + owner, repo, issue_number, assignees: [login], + }); + core.info(`Assigned ${login} to issue #${issue_number}`); + } catch (e) { + core.warning( + `addAssignees on #${issue_number} failed: ${e.message}`, + ); + } + } else if (/^\/untake\s*$/.test(body)) { + try { + await github.rest.issues.removeAssignees({ + owner, repo, issue_number, assignees: [login], + }); + core.info(`Unassigned ${login} from issue #${issue_number}`); + } catch (e) { + core.warning( + `removeAssignees on #${issue_number} failed: ${e.message}`, + ); + } + } else { + core.info( + `Comment does not match exact '/take' or '/untake'; skipping.`, + ); + } + + request-review: + # Job-level startsWith gate avoids spinning up a runner for every + # PR comment; the regex inside the script enforces the exact shape. + if: >- + github.event_name == 'issue_comment' + && github.event.action == 'created' + && github.event.issue.pull_request != null + && github.event.comment.user.type != 'Bot' + && (startsWith(github.event.comment.body, '/request-review') + || startsWith(github.event.comment.body, '/unrequest-review')) + runs-on: ubuntu-latest + steps: + - uses: actions/github-script@v8 + with: + github-token: ${{ secrets.GITHUB_TOKEN }} + script: | + const body = (context.payload.comment.body || '').trim(); + const pull_number = context.payload.issue.number; + const commenter = context.payload.comment.user.login; + const author = context.payload.issue.user.login; + const { owner, repo } = context.repo; + + const match = body.match( + /^\/(request-review|unrequest-review)\b(.*)$/s, + ); + if (!match) { + core.info(`Comment does not match exact command; skipping.`); + return; + } + const action = match[1]; + + // Authorize: PR author always, otherwise commenter must hold + // write/maintain/admin on the repo (i.e. a committer). + let allowed = commenter === author; Review Comment: I think we can just allow PR authors to use this. Committers can use GitHub UI already. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
