Ma77Ball opened a new pull request, #4992: URL: https://github.com/apache/texera/pull/4992
### What changes were proposed in this PR?
Replaced the placeholder spec at
frontend/src/app/workspace/component/left-panel/settings/settings.component.spec.ts
(previously just a license header) with 10 real test cases for
SettingsComponent:
- Component creation
- Form initialization from the current workflow settings
- dataTransferBatchSize validators (min(1) and required)
- confirmUpdateDataTransferBatchSize writes through to
WorkflowActionService and persists when the user is logged in
- The > 0 guard in confirmUpdateDataTransferBatchSize blocks invalid
values
- UserService.isLogin() gate skips persistence when the user is logged out
- updateExecutionMode writes through to the workflow service and persists
- persistWorkflow errors are surfaced via NotificationService.error
- Form valueChanges propagate both controls to the action service
- Form valueChanges ignore invalid values
Also removed settings.component.spec.ts from the placeholder exclusion
lists in frontend/angular.json (test builder exclude) and
frontend/src/tsconfig.spec.json (exclude) so the spec is actually compiled and
run.
### Any related issues, documentation, or discussions?
Closes: #4965
### How was this PR tested?
Ran the new spec via the Angular/Vitest test runner:
npx ng test --watch=false
--include="src/app/workspace/component/left-panel/settings/settings.component.spec.ts"
### Was this PR authored or co-authored using generative AI tooling?
Co-Authored with Claude Opus 4.7 in compliance with ASF
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
