Yicong-Huang commented on code in PR #4276:
URL: https://github.com/apache/texera/pull/4276#discussion_r3212068119
##########
amber/src/main/python/core/storage/iceberg/test_iceberg_document.py:
##########
@@ -37,16 +37,19 @@
# Hardcoded storage config only for test purposes.
StorageConfig.initialize(
+ catalog_type="rest",
postgres_uri_without_scheme="localhost:5432/texera_iceberg_catalog",
postgres_username="texera",
postgres_password="password",
+ rest_catalog_uri="http://localhost:8181/catalog/";,
+ rest_catalog_warehouse_name="texera",
table_result_namespace="operator-port-result",
directory_path="../../../../../../amber/user-resources/workflow-results",
commit_batch_size=4096,
s3_endpoint="http://localhost:9000";,
- s3_region="us-east-1",
- s3_auth_username="minioadmin",
- s3_auth_password="minioadmin",
+ s3_region="us-west-2",
+ s3_auth_username="texera_minio",
+ s3_auth_password="password",
Review Comment:
are those changes intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
