Ma77Ball opened a new pull request, #5006:
URL: https://github.com/apache/texera/pull/5006
### What changes were proposed in this PR?
VirtualIdentityUtils.getWorkerIndex only matched the worker name pattern
with no fallback case, so passing a non-worker ActorVirtualIdentity (e.g.
CONTROLLER, SELF) threw scala.MatchError at runtime. This PR adds a fallback
case that returns -1 for non-worker actor IDs, matching the graceful handling
already present in the sibling methods getPhysicalOpId and toShorterString.
### Any related issues, documentation, discussions?
Closes: #4727
### How was this PR tested?
Updated VirtualIdentityUtilsSpec the existing test that pinned the
MatchError behavior was replaced with a test asserting that getWorkerIndex
returns -1 for special actor IDs like CONTROLLER. The existing test for the
worker-name happy path still passes unchanged.
### Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.7 in compliance with ASF
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
