Yicong-Huang commented on code in PR #4969:
URL: https://github.com/apache/texera/pull/4969#discussion_r3215688574
##########
frontend/src/app/workspace/component/workspace.component.spec.ts:
##########
@@ -16,3 +16,343 @@
* specific language governing permissions and limitations
* under the License.
*/
+
+import { Location } from "@angular/common";
+import { NO_ERRORS_SCHEMA } from "@angular/core";
+import { ComponentFixture, TestBed } from "@angular/core/testing";
+import { HttpClientTestingModule } from "@angular/common/http/testing";
+import { ActivatedRoute, Router } from "@angular/router";
+import { NzMessageService } from "ng-zorro-antd/message";
+import { EMPTY, of, Subject, throwError } from "rxjs";
+
+import { NotificationService } from
"../../common/service/notification/notification.service";
+import { UserService } from "../../common/service/user/user.service";
+import { WorkflowPersistService } from
"../../common/service/workflow-persist/workflow-persist.service";
+import { Workflow } from "../../common/type/workflow";
+import { CodeEditorService } from "../service/code-editor/code-editor.service";
+import { WorkflowCompilingService } from
"../service/compile-workflow/workflow-compiling.service";
+import { OperatorMetadataService } from
"../service/operator-metadata/operator-metadata.service";
+import { UndoRedoService } from "../service/undo-redo/undo-redo.service";
+import { WorkflowConsoleService } from
"../service/workflow-console/workflow-console.service";
+import { WorkflowActionService } from
"../service/workflow-graph/model/workflow-action.service";
+import { OperatorReuseCacheStatusService } from
"../service/workflow-status/operator-reuse-cache-status.service";
+import { EntityType, HubService } from "../../hub/service/hub.service";
+import { commonTestProviders } from "../../common/testing/test-utils";
+import { WorkspaceComponent } from "./workspace.component";
+
+describe("WorkspaceComponent", () => {
+ let component: WorkspaceComponent;
+ let fixture: ComponentFixture<WorkspaceComponent>;
+
+ let workflowActionService: any;
+ let workflowPersistService: any;
+ let operatorMetadataService: any;
+ let userService: any;
+ let undoRedoService: any;
+ let notificationService: any;
+ let hubService: any;
+ let codeEditorService: any;
+ let messageService: any;
+ let routerMock: any;
+ let locationMock: any;
+ let metadataChangedSubject: Subject<void>;
+ let stubGraph: { triggerCenterEvent: ReturnType<typeof vi.fn>;
hasElementWithID: ReturnType<typeof vi.fn> };
+
+ const stubWorkflow: Workflow = {
+ wid: 42,
+ name: "test",
+ creationTime: 0,
+ lastModifiedTime: 0,
+ content: {
+ operators: [],
+ operatorPositions: {},
+ links: [],
+ commentBoxes: [],
+ settings: { dataTransferBatchSize: 100 },
+ },
+ } as unknown as Workflow;
+
+ function configureRoute(params: Record<string, any> = {}, queryParams:
Record<string, any> = {}) {
+ return {
+ snapshot: { params, queryParams, fragment: null as string | null },
+ };
+ }
+
+ async function createFixture(routeOverride: any = configureRoute()) {
+ metadataChangedSubject = new Subject<void>();
+ stubGraph = {
+ triggerCenterEvent: vi.fn(),
+ hasElementWithID: vi.fn().mockReturnValue(false),
+ };
+
+ workflowActionService = {
+ setHighlightingEnabled: vi.fn(),
+ resetAsNewWorkflow: vi.fn(),
+ disableWorkflowModification: vi.fn(),
+ enableWorkflowModification: vi.fn(),
+ reloadWorkflow: vi.fn(),
+ setNewSharedModel: vi.fn(),
+ setWorkflowMetadata: vi.fn(),
+ clearWorkflow: vi.fn(),
+ highlightElements: vi.fn(),
+ getTexeraGraph: vi.fn().mockReturnValue(stubGraph),
+ getWorkflow: vi.fn().mockReturnValue(stubWorkflow),
+ getWorkflowMetadata: vi.fn().mockReturnValue({ wid: 42, readonly: false
}),
+ workflowChanged: vi.fn().mockReturnValue(EMPTY),
+ workflowMetaDataChanged:
vi.fn().mockReturnValue(metadataChangedSubject.asObservable()),
+ };
+
+ workflowPersistService = {
+ isWorkflowPersistEnabled: vi.fn().mockReturnValue(true),
+ persistWorkflow: vi.fn().mockReturnValue(of(stubWorkflow)),
+ retrieveWorkflow: vi.fn().mockReturnValue(of(stubWorkflow)),
+ };
+
+ operatorMetadataService = {
+ getOperatorMetadata: vi.fn().mockReturnValue(of({})),
+ };
+
+ userService = {
+ isLogin: vi.fn().mockReturnValue(true),
+ getCurrentUser: vi.fn().mockReturnValue({ uid: 7 }),
+ };
+
+ undoRedoService = {
+ clearUndoStack: vi.fn(),
+ clearRedoStack: vi.fn(),
+ };
+
+ notificationService = { error: vi.fn() };
+ hubService = { postView: vi.fn().mockReturnValue(of(0)) };
+ codeEditorService = { vc: undefined };
+ messageService = { error: vi.fn() };
+
+ routerMock = { navigate: vi.fn() };
+ locationMock = { go: vi.fn() };
+
+ TestBed.overrideComponent(WorkspaceComponent, {
+ set: { template: '<div #codeEditor class="stub-host"></div>', imports:
[], providers: [] },
Review Comment:
Filed apache/texera#5015 to track this — fix CodeEditorComponent spec first,
then drop the template override here so real children render and we can assert
editor-lifecycle wiring. Added an inline `TODO(#5015)` at the
`overrideComponent` call so the deferral is discoverable from the spec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
