Yicong-Huang commented on PR #4851: URL: https://github.com/apache/texera/pull/4851#issuecomment-4418103457
> ## [Codecov](https://app.codecov.io/gh/apache/texera/pull/4851?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report > ❌ Patch coverage is `93.33333%` with `1 line` in your changes missing coverage. Please review. ✅ Project coverage is 43.21%. Comparing base ([`deb0e2c`](https://app.codecov.io/gh/apache/texera/commit/deb0e2cfc979767e07248a75261da5ec98e3ae3e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`dd50017`](https://app.codecov.io/gh/apache/texera/commit/dd50017542efdfd7e0b6422b505664cd3edf17d8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). > > [Files with missing lines](https://app.codecov.io/gh/apache/texera/pull/4851?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Patch % Lines > [...c/main/scala/org/apache/texera/dao/SqlServer.scala](https://app.codecov.io/gh/apache/texera/pull/4851?src=pr&el=tree&filepath=common%2Fdao%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Ftexera%2Fdao%2FSqlServer.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL2Rhby9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL3RleGVyYS9kYW8vU3FsU2VydmVyLnNjYWxh) 93.33% [1 Missing ⚠️ ](https://app.codecov.io/gh/apache/texera/pull/4851?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) > Additional details and impacted files > [☔ View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/texera/pull/4851?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). 📢 Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > > 🚀 New features to boost your workflow: @Ma77Ball I think the missing line is about close(). can we add a test against it? thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
