nathant27 commented on issue #4726:
URL: https://github.com/apache/texera/issues/4726#issuecomment-4427305816
Also, another question I have is on the behavior for Heartbeat.run
```
@overrides
def run(self) -> None:
while not self._stop_event.wait(timeout=self._interval):
alive = self._check_heartbeat()
if not alive:
# double check
still_alive = self._check_heartbeat()
if not still_alive:
parent_pid = os.getppid()
```
Is there a reason why we double check if not alive twice besides double
checking for a close raising an exception and returning false in
_check_heartbeat? If it's only for that purpose, can I remove the redundant if
check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
