Ma77Ball opened a new pull request, #5037:
URL: https://github.com/apache/texera/pull/5037
### What changes were proposed in this PR?
Drops the `<div #codeEditor>` template stub from `WorkspaceComponent`'s
unit spec so the real `workspace.component.html` renders. Heavyweight children
(workflow editor, panels, menu) are kept out of the test build by stripping
the component's `imports`/`providers` and adding
`CUSTOM_ELEMENTS_SCHEMA`, leaving the `<ng-template #codeEditor>` outlet free
to wire a live `ViewContainerRef` into `CodeEditorService.vc`. A new `child
rendering side
effects` describe block asserts that the editor-lifecycle wiring runs
end-to-end (the published outlet is a real `ViewContainerRef`, proven by
`createEmbeddedView` being a function on it).
### Any related issues, documentation, or discussions?
Closes: #5015
### How was this PR tested?
- `yarn test
--include="src/app/workspace/component/workspace.component.spec.ts"
--watch=false`: 20/20 pass (19 prior tests preserved, 1 new).
- `yarn test --watch=false`: full suite 445 passed, 2 skipped, 2 todo (no
regressions).
- `yarn format:fix`: no rewrites.
### Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.7 in compliance with ASF
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
