aglinxinyuan commented on PR #4956: URL: https://github.com/apache/texera/pull/4956#issuecomment-4436682000
Thanks @Yicong-Huang — addressed all three asks in [cd5bb17138](https://github.com/apache/texera/pull/4956/commits/cd5bb17138): | Request | Resolution | | --- | --- | | Self-loop rejection | Added `require(fromOpId != toOpId, …)` to the primary constructor; throws `IllegalArgumentException`. Covered by tests on both construction paths. | | Empty / null op-id rejection | Added `require(fromOpId != null && fromOpId.id != null && fromOpId.id.nonEmpty, …)` (same for `toOpId`). Covered by primary-constructor and `@JsonCreator` tests. Jackson's missing-field path now also throws (wrapped in `ValueInstantiationException`). | | Asymmetric serde follow-up | Filed [#5042](https://github.com/apache/texera/issues/5042) (Bug). The existing characterization test now links the issue and notes it must flip to a passing round-trip when the fix lands. | Test count went from 12 → 18 (added 6 rejection tests across both construction paths and Jackson). Updated the PR title to `feat(amber): …` since this no longer is test-only. Verified: ``` sbt "WorkflowExecutionService/Test/testOnly org.apache.texera.workflow.LogicalLinkSpec" # 18 pass sbt "WorkflowExecutionService/Test/testOnly org.apache.texera.workflow.WorkflowCompilerSpec" # 6 pass (regression) sbt "WorkflowExecutionService/Test/testOnly org.apache.texera.amber.engine.architecture.scheduling.CostBasedScheduleGeneratorSpec" # 7 pass (regression — many LogicalLinks) sbt "WorkflowExecutionService/Test/scalafmtCheck" "WorkflowExecutionService/scalafmtCheck" # clean ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
