Ma77Ball opened a new pull request, #5046:
URL: https://github.com/apache/texera/pull/5046
### What changes were proposed in this PR?
The `executor_manager` fixture in `test_executor_manager.py` guarded its
cleanup with `hasattr(manager, "_fs")`, but the `@cached_property` attribute is
named `fs`, so the guard was
always false and `manager.close()` never ran. This leaked `TempFS`
directories into `/var/tmp` on every test run. Even when `close()` did run from
the sibling fixture, it only closed
the filesystem and left stale `udf-vN` entries in `sys.modules` plus the
tmp directory in `sys.path`. This PR drops the broken guard and extends
`ExecutorManager.close()` to also
remove the module from `sys.modules` and the path from `sys.path`, so a
single `close()` call fully reverses every global side effect of `fs` and
`load_executor_definition`.
### Any related issues, documentation, or discussions?
Closes: #4730
### How was this PR tested?
* All 20 tests in `test_executor_manager.py` pass.
* Verified `/var/tmp` no longer accumulates `TempFS` directories after a
test run.
* Verified no leaked `udf-v*` files anywhere under `/tmp` or `/var/tmp`
after a run.
### Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.7 in compliance with ASF
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
