Ma77Ball opened a new pull request, #5051:
URL: https://github.com/apache/texera/pull/5051
### What changes were proposed in this PR?
`VirtualIdentityUtils.createWorkerIdentity` now rejects layer names
containing `-` via `require`. The worker-name format
`Worker:WF<id>-<op>-<layer>-<workerId>` is inherently ambiguous when both `op`
and `layer` may contain `-`, and production operator IDs (e.g.
`ClassName-UUID`) structurally must. Layer names in production are always
hyphen-free (`main`, `build`, `probe`, `localAgg`, `globalAgg`); this change
lifts that invariant from "implied by the regex" to "enforced at the boundary",
so callers fail loudly at construction instead of silently mis-parsing later.
Two `WorkerSpec` test fixtures (`"1st-physical-op"`, `"2nd physical-op"`) are
renamed to hyphen-free equivalents; they only needed to be two distinct strings.
### Any related issues, documentation, or discussions?
Closes: #4728
### How was this PR tested?
The previously-pinned `VirtualIdentityUtilsSpec` bug spec ("misparse layer
names that contain hyphens (current behavior)") is replaced with a spec
asserting that `createWorkerIdentity` rejects hyphenated layer names. Existing
`VirtualIdentityUtilsSpec`, `WorkerSpec`, and the Python
`test_virtual_identity.py` cases continue to pass (Python's `get_worker_index`
only extracts the trailing index group and is unaffected).
### Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.7 in compliance with ASF
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
