Copilot commented on code in PR #5092:
URL: https://github.com/apache/texera/pull/5092#discussion_r3252133984
##########
amber/src/main/python/core/storage/iceberg/iceberg_document.py:
##########
@@ -211,9 +212,9 @@ def _seek_to_usable_file(self) -> Iterator[FileScanTask]:
self.num_of_skipped_records += record_count
continue
yield task
- except Exception:
- print("Could not read iceberg table:\n")
- raise Exception
+ except Exception as err:
+ logger.exception(err)
+ raise
Review Comment:
This error-preservation behavior is not covered by an automated test, even
though `test_iceberg_document.py` already covers this storage component. A
small mocked failure of `refresh()` or `_extract_sorted_file_scan_tasks()`
would guard against reintroducing the previous `raise Exception` regression and
verify callers observe the original exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
