aglinxinyuan commented on PR #4997: URL: https://github.com/apache/texera/pull/4997#issuecomment-4484846133
> Also the test coverage is not enough. > > > Patch coverage is 47.14286% with 37 lines in your changes missing coverage. Please review. > > I especially want to make sure the following can still work. If we do not currently have test coverage, it will be ideal to add tests for them first before upgrade. > > 1. language client features can still work > 2. our custom editor logics (e.g., frozen editor during execution, unfreeze when paused). > 3. debugger logics (with Monaco-breakpoint) I tried to improve the general test coverage for the editor in PR #5004. I also tested the editor features manually for this PR. If full test coverage is required for all 3 points you mentioned before upgrading, I don't plan to move forward with this PR, as I don't have enough bandwidth. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
