carloea2 commented on code in PR #5043: URL: https://github.com/apache/texera/pull/5043#discussion_r3271507313
########## frontend/src/app/workspace/service/code-editor/ui-udf-parameters-parser.service.ts: ########## @@ -0,0 +1,217 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import { Injectable } from "@angular/core"; +import { parser } from "@lezer/python"; +import { AttributeType, SchemaAttribute } from "../../types/workflow-compiling.interface"; + +export interface UiUdfParameter { + attribute: SchemaAttribute; + value: string; +} + +const CLASSES = new Set(["ProcessTupleOperator", "ProcessBatchOperator", "ProcessTableOperator", "GenerateOperator"]); Review Comment: Yes, this is intentional for this frontend foundation PR. We can later add extensions. The parser follows the Python UDF template class names that the operator descriptors generate/use directly, so custom-named subclasses such as `class MyOp(ProcessTupleOperator):` are intentionally ignored for now rather than partially supported only in the frontend. I added both pieces requested: 1. A one-line comment pointing future maintainers to the backend descriptor sources. 2. A test documenting the custom subclass behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
