bobbai00 opened a new pull request, #5160:
URL: https://github.com/apache/texera/pull/5160

   ### What changes were proposed in this PR?
   
   Makes `toggleRegion()` in `menu.component.ts` toggle the `hide-region` CSS 
class on the main paper element, in addition to the existing `body/visibility` 
attribute flip. Follows the same pattern as the neighbouring 
`toggleNumWorkers()` / `toggleStatus()` toggles.
   
   The main editor permanently carries `hide-region`, whose SCSS rule `display: 
none`s every `.region` child, so the existing `body/visibility` attribute 
change had no effect on the main canvas — only on the mini-map (which doesn't 
carry the class). With this change, the class is added/removed in sync with 
`showRegion`, and the existing attribute flip continues to drive the mini-map.
   
   ### Any related issues, documentation, discussions?
   
   Closes #5120
   
   Regression from #4495.
   
   ### How was this PR tested?
   
   Manually verified in the browser against a workflow with multiple connected 
operators and at least one executed region:
   
   1. Load workflow, run it so region updates are emitted.
   2. View → Regions OFF (default): hulls hidden on both main canvas and 
mini-map.
   3. Toggle ON: hulls appear on both surfaces.
   4. Toggle OFF: hulls disappear on both surfaces.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Opus 4.7 (1M context)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to