mengw15 commented on code in PR #5164:
URL: https://github.com/apache/texera/pull/5164#discussion_r3293612332


##########
amber/src/main/scala/org/apache/texera/web/resource/GmailResource.scala:
##########
@@ -146,7 +147,11 @@ class GmailResource {
   @Path("/send")
   def sendEmailRequest(emailMessage: EmailMessage, @Auth user: SessionUser): 
Unit = {
     val recipientEmail = if (emailMessage.receiver.isEmpty) user.getEmail else 
emailMessage.receiver
-    sendEmail(emailMessage, recipientEmail)
+    sendEmail(emailMessage, recipientEmail) match {
+      case Right(_) => ()

Review Comment:
   Done. Left("Invalid email format") now throws BadRequestException (HTTP 
400); SMTP failures continue to return 502.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to