Yicong-Huang opened a new pull request, #5181: URL: https://github.com/apache/texera/pull/5181
### What changes were proposed in this PR? `list-item`, `share-access`, and `user-dataset-file-renderer` each constructed a `ComponentFixture` via `TestBed.createComponent` but never triggered change detection. The template's creation pass therefore never ran, the source-map-attributed v8 coverage stayed at 0 % for the corresponding `.component.html`, and the specs still passed green — exactly the failure mode documented as golden rule #1 in `frontend/AGENTS.md` and in `frontend/TESTING.md` §"Why detectChanges() is the coverage switch". Adds `fixture.detectChanges()` to each: - `list-item.component.spec.ts` — seeds `component.entry` with a fully-formed workflow entry in `beforeEach` before calling `detectChanges()`. The component's `entry` getter throws when `_entry` is undefined and `initializeEntry()` (called from `ngOnChanges`) reads `entry.workflow.isOwner`, `accessibleUserIds`, and counters, so a minimal stub is not enough. Each `it` block continues to overwrite `component.entry` and assert on confirm-method behavior; no existing assertions change. - `share-access.component.spec.ts` — `detectChanges()` lives in the `setupComponent` helper so every test case picks it up. - `user-dataset-file-renderer.component.spec.ts` — `detectChanges()` in `beforeEach` after `createComponent`. `ngOnInit -> reloadFileContent` hits the unsupported-MIME bail with the default empty `filePath`, so no service calls fire. ### Any related issues, documentation, discussions? Closes #5180. The rule itself was documented in #5170 (the frontend testing guide). ### How was this PR tested? `yarn ng test --watch=false --include=…` against the three affected specs locally: 3 files, 10 tests, all pass. `yarn format:ci` clean. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Opus 4.7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
