Yicong-Huang commented on code in PR #5201:
URL: https://github.com/apache/texera/pull/5201#discussion_r3299423527
##########
amber/src/main/scala/org/apache/texera/web/auth/JwtAuth.scala:
##########
@@ -25,8 +25,8 @@ import io.dropwizard.setup.Environment
import org.apache.texera.auth.JwtAuth.jwtConsumer
import org.apache.texera.auth.SessionUser
-// TODO: move this logic to Auth
-@Deprecated
+// TODO: move this logic to common/auth once it depends on Dropwizard, so amber
+// services can drop the toastshaman dropwizard-auth-jwt filter.
Review Comment:
Removing the deprecated is a behavior change. Let's keep the deprecation. It
is fine to keep that in warning. The way to remove this warning is to actually
remove this code
##########
file-service/src/main/scala/org/apache/texera/service/type/serde/DatasetFileNodeSerializer.java:
##########
@@ -53,7 +53,7 @@ public void serialize(DatasetFileNode value, JsonGenerator
gen, SerializerProvid
gen.writeFieldName("children");
gen.writeStartArray();
List<DatasetFileNode> children = value.getChildren();
- for (DatasetFileNode child :
JavaConverters.seqAsJavaList(children)) {
+ for (DatasetFileNode child :
CollectionConverters.asJava(children)) {
Review Comment:
Can we turn this one into an error? So that it can prevent the wrong pattern
being introduced again.
##########
common/workflow-operator/src/main/scala/org/apache/texera/amber/operator/TestOperators.scala:
##########
@@ -140,25 +139,6 @@ object TestOperators {
aggOp
}
- def inMemoryMySQLSourceOpDesc(
Review Comment:
MySQL exec implementation was disabled due to license issue. We can remove
this (used for test) for now. @bobbai00 whats our plan to add mysql back?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
