xuang7 commented on PR #5171: URL: https://github.com/apache/texera/pull/5171#issuecomment-4537408053
> LGTM! Thanks for the fix! Before merge, could you run last manual test, thanks! One behavior worth flagging: an owner with explicit access to an orphan dataset may still see it in their list with size=0. The accessible-datasets path in `listDatasets` doesn't call LakeFS, so the try-catch can't fire there — maybe only the publicDatasets path drops orphans. Probably actually fine — owner sees a "broken dataset" instead of "my dataset silently disappeared", which is arguably more informative. Sounds good! In this version, the owner can still see the broken dataset in the list. I think it may be okay to keep this behavior for now, since keeping it visible can serve as a reminder that something is inconsistent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
