xuang7 commented on PR #5215: URL: https://github.com/apache/texera/pull/5215#issuecomment-4540203461
> I find myself not liking the cover image for a dataset. in fact in real usage, it's unlikely for a user to spend time to find a cover image for a dataset: it will likely become the default image instead. > > Thus I suggest remove the image, or at least make it optional. Thanks for the suggestion! I agree that many datasets may not have a custom cover image in real usage, and it is possible that most of them will fall back to the default image, similar to what we currently have on the Hub featured workflow. <img width="522" height="253" alt="Screenshot 2026-05-25 at 9 52 39 PM" src="https://github.com/user-attachments/assets/1d248b1c-919e-48d1-b099-c72909a40b84"; /> I think the image area helps make the card view more visually distinguishable, since we do not have many metadata fields yet, such as tags, dataset format, or subtitle/summary information. Without an image, the cards may look a bit plain and information-heavy. That said, we could also make the image optional, use a more compact layout where the cover image takes up a smaller portion of the card, like the example shown above, or remove it entirely. I'm open to adjusting the design. <img width="345" height="225" alt="sample" src="https://github.com/user-attachments/assets/ee1ded08-e353-48ee-a829-91c192e71439"; /> I will add more tests to improve the coverage. I'm still considering whether to split this into two smaller PRs since the current PR is getting a bit large. Thanks! @Yicong-Huang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
