Ma77Ball commented on code in PR #5077:
URL: https://github.com/apache/texera/pull/5077#discussion_r3301916602


##########
.github/workflows/build.yml:
##########
@@ -206,6 +206,24 @@ jobs:
         with:
           distribution: "temurin"
           java-version: 17
+      - name: Setup Python for proto-gen

Review Comment:
   This job builds the Amber dist zip. build.sbt:55 adds amber/src/main/python 
as a source dir, so the dist packages everything under it — including 
amber/src/main/python/proto/. Since 9ccc77ae7 untracked those proto files, they 
only exist on disk after bin/python-proto-gen.sh runs.
   
   > [!WARNING]
   > Skip the proto-gen step → the dist ships with proto/ empty → downstream 
jobs (amber-integration:, dockerfile builds) crash at Python import time when 
workers hit from proto.* import ....



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to