Yicong-Huang opened a new pull request, #5434:
URL: https://github.com/apache/texera/pull/5434
### What changes were proposed in this PR?
`WorkflowExecutionsResource.insertOperatorPortResultUri` was a static method
on a JAX-RS web resource that issued
`context.insertInto(OPERATOR_PORT_EXECUTIONS).columns(...).values(...).execute()`
— duplicating, by hand, what `OperatorPortExecutionsDao.insert(pojo)` already
does. The engine's `RegionExecutionCoordinator` reached into the web layer to
call this helper. With the helper removed and the call site rewritten to use
the generated DAO directly inside
`withTransaction(SqlServer.getInstance().createDSLContext()) { ctx => ... }` —
the canonical engine-side pattern, as in `CostEstimator` — the engine no longer
imports `WorkflowExecutionsResource`.
`WorkflowExecutionsResourceSpec` had seven references to the removed method:
one dedicated test (now dropped — it was asserting jOOQ's own insert contract)
and six fixture setups for tests of other behaviors. The six fixture setups now
go through a spec-local `insertPortResultUri` helper that mirrors the
production DAO pattern.
### Any related issues, documentation, discussions?
Closes #5430. Sub-issue of #5424 — eliminates one of the four engine→web
import leaks blocking the amber Dropwizard upgrade tracked in #5423.
### How was this PR tested?
`sbt 'WorkflowExecutionService/testOnly *WorkflowExecutionsResourceSpec'` —
22 tests pass. `sbt scalafmtCheckAll` clean.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.7)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
