Ma77Ball opened a new issue, #5442: URL: https://github.com/apache/texera/issues/5442
### Task Summary Remove the unused `hocon-parser` integration from `pyright-language-service`. It is dead code: `hoconParser` was used in `main.ts` to parse the Amber HOCON config, but that call was removed in #3150 (when the language server became a standalone microservice) and the leftover import was removed in #3415. The dependency, the type stub, and a sibling `hoconjs` dependency were never cleaned up. This came up in #5435, which tried to improve the stub's return type. Since nothing uses it, removing it is the better change. **What to do:** - [ ] Delete `pyright-language-service/src/types/hocon-parser.d.ts` - [ ] Remove `hocon-parser` (line 9) and `hoconjs` (line 10) from `pyright-language-service/package.json` - [ ] Run `yarn install` in `pyright-language-service/` to update `yarn.lock` **Acceptance criteria:** - [ ] `grep -rn "hocon" pyright-language-service/src` returns nothing - [ ] `yarn build` (or the existing TypeScript build) in `pyright-language-service/` still passes **Pointers (where it used to live):** - Original usage added in #2823 (`core/pyright-language-server/src/main.ts`) - Call removed in #3150, import removed in #3415 ### Task Type - [x] Refactor / Cleanup - [ ] DevOps / Deployment / CI - [ ] Testing / QA - [ ] Documentation - [ ] Performance - [ ] Other -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
