mengw15 commented on PR #5459: URL: https://github.com/apache/texera/pull/5459#issuecomment-4643775610
> I am only speculating here: maybe the test target has already been tested through other tests? For example, suppose > > * `foo()` is a helper method, and had no tests before. > * `main()` is an entry method, which calls `foo()` inside, and had tests. > > Now if you add tests against `foo()`, it won't help because `foo()` has been covered by `main()`'s tests before. > > Thus to look for adding more tests, it is not about "which file has no test", but "which code line has not been covered". I believe for this PR it's actually the opposite — auth-guard.service.ts had no prior coverage at all. On the base it shows up as null (not 0%), i.e. it wasn't in the coverage report at all, because nothing loaded it. After this spec it's at 100%. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
