Yicong-Huang commented on code in PR #5317:
URL: https://github.com/apache/texera/pull/5317#discussion_r3384784267
##########
.github/workflows/welcome-first-time-contributor.yml:
##########
@@ -108,41 +108,13 @@ jobs:
MARKER,
`👋 Thanks for your first contribution to Texera, @${author}!`,
``,
- `You can drive common housekeeping tasks just by leaving a
comment. Type the command on its own line.`,
Review Comment:
let's keep these two longer version sentences as they are clearer
##########
.github/workflows/welcome-first-time-contributor.yml:
##########
@@ -108,41 +108,13 @@ jobs:
MARKER,
`👋 Thanks for your first contribution to Texera, @${author}!`,
``,
- `You can drive common housekeeping tasks just by leaving a
comment. Type the command on its own line.`,
+ `Drive common housekeeping by commenting a command on its own
line:`,
``,
- `### On issues`,
+ `- **Issues:** \`/take\` (self-assign), \`/untake\`. Find
unclaimed work via \`is:issue is:open no:assignee\`.`,
Review Comment:
also mention one sentence about `starter-task` label. suggest start with
those.
##########
.github/workflows/welcome-first-time-contributor.yml:
##########
@@ -108,41 +108,13 @@ jobs:
MARKER,
`👋 Thanks for your first contribution to Texera, @${author}!`,
``,
- `You can drive common housekeeping tasks just by leaving a
comment. Type the command on its own line.`,
+ `Drive common housekeeping by commenting a command on its own
line:`,
``,
- `### On issues`,
+ `- **Issues:** \`/take\` (self-assign), \`/untake\`. Find
unclaimed work via \`is:issue is:open no:assignee\`.`,
+ `- **Sub-issues:** on the parent, \`/sub-issue #5166 #5222\` /
\`/unsub-issue #5166 #5222\`; on the child, \`/parent-issue #5166\` /
\`/unparent-issue\` (parent auto-detected). Refs can be \`#5166\` or bare
\`5166\`; cross-repo refs aren't supported.`,
Review Comment:
actually, for all three parts, issues, subissues, prs, make them a bit
longer. the compact version is a bit too compacted which loses clarity.
##########
.github/workflows/welcome-first-time-contributor.yml:
##########
@@ -108,41 +108,13 @@ jobs:
MARKER,
`👋 Thanks for your first contribution to Texera, @${author}!`,
``,
- `You can drive common housekeeping tasks just by leaving a
comment. Type the command on its own line.`,
+ `Drive common housekeeping by commenting a command on its own
line:`,
``,
- `### On issues`,
+ `- **Issues:** \`/take\` (self-assign), \`/untake\`. Find
unclaimed work via \`is:issue is:open no:assignee\`.`,
+ `- **Sub-issues:** on the parent, \`/sub-issue #5166 #5222\` /
\`/unsub-issue #5166 #5222\`; on the child, \`/parent-issue #5166\` /
\`/unparent-issue\` (parent auto-detected). Refs can be \`#5166\` or bare
\`5166\`; cross-repo refs aren't supported.`,
Review Comment:
can be a bit longer. current version is not very clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
